-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NODE-5388): add release automation #22
Conversation
(Just taking note) This package does not have the same deadline as others, review can wait until we need release automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look good, but it's hard to know without testing. Have you tested on a fork / given thought to how we can test these changes?
It is tough because of all the system specific packages, I don't think I could set up a fork capable of the same release pattern. I think releasing an alpha would be the best way to test, I will look into how napi-rs can be told to set the publish tag (if not possible it could be updated after releasing) For SSDLC, currently, each package is built and released by napi-rs "automatically" in the sense that it uses the "npm/" directory to determine packages to release and that's all done as one step, are we going to have to "take over" that step so we can insert signing? maybe it would be easier to test once we own that part. |
Alpha sounds good. But are you suggesting we just hold off on this PR until we tackle SSDLC for it? That's also fine with me, I'll just take my face off of it on the Kanban board.
I don't think so - there's already a step in the existing CI that |
SSDLC work will have larger changes to this package in the near future, we will revisit release automation then and port over the work from kerberos and mongodb-client-encyrption. |
Description
What is changing?
Overview:
NPM_CONFIG_PROVENANCE
)Is there new documentation needed for these changes?
No
What is the motivation for this change?
Double check the following
npm run format:js && npm run format:rs
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript